----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63987/#review193114 -----------------------------------------------------------
src/main/assembly/plugin-atlas.xml Line 57 (original), 57 (patched) <https://reviews.apache.org/r/63987/#comment271611> Patch fails to apply. Could you please check? ``` $ git apply --check -v < ~/Downloads/RANGER-1905-3.patch Checking patch agents-audit/pom.xml... Checking patch embeddedwebserver/scripts/ranger-admin-services.sh... Checking patch src/main/assembly/plugin-atlas.xml... error: while searching for: <include>org.apache.httpcomponents:httpmime:jar:${httpcomponents.httpmime.version}</include> <include>org.apache.hadoop:hadoop-hdfs:jar:${hadoop.version}</include> <include>org.apache.solr:solr-solrj</include> </includes> <unpack>false</unpack> </dependencySet> error: patch failed: src/main/assembly/plugin-atlas.xml:57 error: src/main/assembly/plugin-atlas.xml: patch does not apply ``` - Velmurugan Periasamy On Nov. 28, 2017, 10:41 a.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63987/ > ----------------------------------------------------------- > > (Updated Nov. 28, 2017, 10:41 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-1905 > https://issues.apache.org/jira/browse/RANGER-1905 > > > Repository: ranger > > > Description > ------- > > As ranger-plugins-audit doesn't exclude guava from hadoop common, an older > guava > is leaked into embeddedwebserver classpath, which somehow filtered out by the > assembly plugin. > If we explicitly exclude the old guava, and include the new (17.0) guava in > ranger-plugins-audit module, the generated tar.gz/zip distributions will > contain the necessary guava-17.0.jar in ews/lib path. > > > Diffs > ----- > > agents-audit/pom.xml c8bd1d8f3 > embeddedwebserver/scripts/ranger-admin-services.sh 278aab6c9 > src/main/assembly/plugin-atlas.xml fd988116d > > > Diff: https://reviews.apache.org/r/63987/diff/3/ > > > Testing > ------- > > Tested with executing: > > mvn -DskipTests package assembly:assembly; > unzip -Z1 target/ranger-1.0.0-SNAPSHOT-admin.zip | sort > FILES.txt > > And comparing the results with different versions. With the patch, the guava > jar appears correctly. > > > Thanks, > > Zsombor Gegesy > >
