----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65828/#review198376 -----------------------------------------------------------
Fix it, then Ship it! tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java Lines 47 (patched) <https://reviews.apache.org/r/65828/#comment278512> Consider extracting fields in the constructor itself and storing them as members, so that accessor methods can simply return them: - RangerAtlasEntity entity; - String entityTypeName; - entityNotificationType notificationType; - Map<String, Map<String, String>> allClassifications; - boolean isEntityTypeHandled; - boolean isEntityDeleteOp; tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java Lines 158 (patched) <https://reviews.apache.org/r/65828/#comment278510> allClassifications could be null. Please update to handle this case. tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java Lines 176 (patched) <https://reviews.apache.org/r/65828/#comment278511> allTraits could be null. Please update to handle this case. - Madhan Neethiraj On Feb. 28, 2018, 3:11 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65828/ > ----------------------------------------------------------- > > (Updated Feb. 28, 2018, 3:11 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-1997 > https://issues.apache.org/jira/browse/RANGER-1997 > > > Repository: ranger > > > Description > ------- > > Atlas is upgraded to emit more efficient Entity Notifications (of type V2). > Tagsync is updated to handle them. > > > Diffs > ----- > > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java > 91cf606af > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java > 8c15ee58b > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java > PRE-CREATION > > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasEntityWithTags.java > b25a24127 > > > Diff: https://reviews.apache.org/r/65828/diff/1/ > > > Testing > ------- > > Tested with local VM > > > Thanks, > > Abhay Kulkarni > >
