> On Feb. 28, 2018, 6:28 a.m., Madhan Neethiraj wrote:
> > tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java
> > Lines 47 (patched)
> > <https://reviews.apache.org/r/65828/diff/1/?file=1967059#file1967059line47>
> >
> > Consider extracting fields in the constructor itself and storing them
> > as members, so that accessor methods can simply return them:
> > - RangerAtlasEntity entity;
> > - String entityTypeName;
> > - entityNotificationType notificationType;
> > - Map<String, Map<String, String>> allClassifications;
> > - boolean isEntityTypeHandled;
> > - boolean isEntityDeleteOp;
Added following data items as members and initialized them in the constructor.
Provided accessors for these members.
RangerAtlasEntity rangerAtlasEntity;
String entityTypeName;
EntityNotification.EntityNotificationType notificationType;
boolean isEntityTypeHandled;
boolean isEntityDeleteOp;
boolean isEmptyClassifications;
- Abhay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65828/#review198376
-----------------------------------------------------------
On Feb. 28, 2018, 3:11 a.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/65828/
> -----------------------------------------------------------
>
> (Updated Feb. 28, 2018, 3:11 a.m.)
>
>
> Review request for ranger and Madhan Neethiraj.
>
>
> Bugs: RANGER-1997
> https://issues.apache.org/jira/browse/RANGER-1997
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Atlas is upgraded to emit more efficient Entity Notifications (of type V2).
> Tagsync is updated to handle them.
>
>
> Diffs
> -----
>
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasNotificationMapper.java
> 91cf606af
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/AtlasTagSource.java
> 8c15ee58b
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlas/EntityNotificationWrapper.java
> PRE-CREATION
>
> tagsync/src/main/java/org/apache/ranger/tagsync/source/atlasrest/RangerAtlasEntityWithTags.java
> b25a24127
>
>
> Diff: https://reviews.apache.org/r/65828/diff/1/
>
>
> Testing
> -------
>
> Tested with local VM
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
