----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66024/#review199942 -----------------------------------------------------------
Ship it! Ship It! - Qiang Zhang On March 24, 2018, 12:18 p.m., Zsombor Gegesy wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66024/ > ----------------------------------------------------------- > > (Updated March 24, 2018, 12:18 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2016 > https://issues.apache.org/jira/browse/RANGER-2016 > > > Repository: ranger > > > Description > ------- > > There is a code path, where a null is passed as a HttpServletRequest - to > trigger 'searching with empty filter'. > A simple fix is to introduce a getServicePolicies(serviceName,SearchFilter) > method on ServiceREST class, so the HttpServletRequest is not needed anymore, > and this method can be called freely. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > c2783dcf6 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 3642252f1 > > > Diff: https://reviews.apache.org/r/66024/diff/3/ > > > Testing > ------- > > Tested locally > > > Thanks, > > Zsombor Gegesy > >
