----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66810/#review202126 -----------------------------------------------------------
Fix it, then Ship it! plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java Lines 404 (patched) <https://reviews.apache.org/r/66810/#comment283761> Consider replacing method parameter "List<String> types" with "String typeName", and call this method only when one typeName is present for 'entity-types' resource. - Madhan Neethiraj On April 26, 2018, 12:36 p.m., Nixon Rodrigues wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66810/ > ----------------------------------------------------------- > > (Updated April 26, 2018, 12:36 p.m.) > > > Review request for ranger, Madhan Neethiraj, Mehul Parikh, and Ramesh Mani. > > > Bugs: RANGER-2085 > https://issues.apache.org/jira/browse/RANGER-2085 > > > Repository: ranger > > > Description > ------- > > This patch includes changes to add resource lookup for entity-id in Atlas > service. > > > Diffs > ----- > > > plugin-atlas/src/main/java/org/apache/ranger/services/atlas/RangerServiceAtlas.java > 671d2d14f4dda0274fac3d9b039597360348ca18 > src/main/assembly/admin-web.xml 73bf8c05b7b8f0e5d2fea4b2e446c1f087b9788b > > > Diff: https://reviews.apache.org/r/66810/diff/1/ > > > Testing > ------- > > Searched with names of entity with starting characters in text-box then > entities with qualified names are loading in dropdown of selected type. > > > Thanks, > > Nixon Rodrigues > >
