----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67206/#review204059 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java Lines 64 (patched) <https://reviews.apache.org/r/67206/#comment286452> "name is in mixed/upper case" ==> "{0}: invalid name. Name should consist of only lower case characters" - Velmurugan Periasamy On May 18, 2018, 4:40 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67206/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 4:40 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2108 > https://issues.apache.org/jira/browse/RANGER-2108 > > > Repository: ranger > > > Description > ------- > > Ranger policy validations depend on resource names and access-type names > being lower case. A corresponding validation check should ensure that all > resource and access-type names in the service definitions too are in lower > case, and fail to validate the service definition if not so. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > ab120b729 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > d5f3fe5c9 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > 55973f545 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > 72c4520b7 > > > Diff: https://reviews.apache.org/r/67206/diff/1/ > > > Testing > ------- > > Wrote corresponding unit test. Ran all unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
