-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67206/
-----------------------------------------------------------
(Updated May 30, 2018, 8:49 p.m.)
Review request for ranger and Madhan Neethiraj.
Changes
-------
Addressed review comment
Bugs: RANGER-2108
https://issues.apache.org/jira/browse/RANGER-2108
Repository: ranger
Description
-------
Ranger policy validations depend on resource names and access-type names being
lower case. A corresponding validation check should ensure that all resource
and access-type names in the service definitions too are in lower case, and
fail to validate the service definition if not so.
Diffs (updated)
-----
agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java
ab120b729
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java
d5f3fe5c9
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java
55973f545
agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java
72c4520b7
Diff: https://reviews.apache.org/r/67206/diff/2/
Changes: https://reviews.apache.org/r/67206/diff/1-2/
Testing
-------
Wrote corresponding unit test. Ran all unit tests successfully.
Thanks,
Abhay Kulkarni
