----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67438/#review204298 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On June 5, 2018, 1:39 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67438/ > ----------------------------------------------------------- > > (Updated June 5, 2018, 1:39 a.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, and Velmurugan > Periasamy. > > > Bugs: RANGER-2108 > https://issues.apache.org/jira/browse/RANGER-2108 > > > Repository: ranger > > > Description > ------- > > This is an update to an earlier commit > (https://git-wip-us.apache.org/repos/asf?p=ranger.git;a=commit;h=268512adc3170bb7799c29e3c5aa064750b9e9e7) > for the same issue. There may be existing service-defs which have mixed case > access-type names, and resource-names containing hyphens/underscore > characters. This patch handles such cases. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/errors/ValidationErrorCode.java > fbe3030c6 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > 3f9315a7e > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > bdac64019 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > 1fafb12fb > > > Diff: https://reviews.apache.org/r/67438/diff/3/ > > > Testing > ------- > > Updated unit test cases, ran all unit tests successfully. > > > Thanks, > > Abhay Kulkarni > >
