----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68076/#review206601 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java Lines 89 (patched) <https://reviews.apache.org/r/68076/#comment289621> Consider using debug log-level in line #89 and #101. security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java Lines 248 (patched) <https://reviews.apache.org/r/68076/#comment289633> if possible, move this to a method in RangerTagDBRetriever and call it from both load paths: same-thread and separate-thread. - Madhan Neethiraj On July 27, 2018, 12:06 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68076/ > ----------------------------------------------------------- > > (Updated July 27, 2018, 12:06 a.m.) > > > Review request for ranger, Madhan Neethiraj, Ramesh Mani, Sailaja Polavarapu, > and Velmurugan Periasamy. > > > Bugs: RANGER-2165 > https://issues.apache.org/jira/browse/RANGER-2165 > > > Repository: ranger > > > Description > ------- > > Ensure that any entities cached in JPA layer during policy/tag cache refresh > are cleared when refresh is completed. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > e7e8cf519 > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyRetriever.java > 463957c49 > > security-admin/src/main/java/org/apache/ranger/biz/RangerTagDBRetriever.java > 55505723d > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 8efc950ce > security-admin/src/main/java/org/apache/ranger/biz/TagDBStore.java > 8341a7354 > > > Diff: https://reviews.apache.org/r/68076/diff/1/ > > > Testing > ------- > > Triggered policy/tag downloads from plugins. Ensured that policies/tags are > correctly retrieved and downloaded to plugins. Ensured that if policy cache > is refreshed as part of policy create/update, then any subsequent database > interactions are completed in expected time. > > > Thanks, > > Abhay Kulkarni > >
