----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68211/#review208484 -----------------------------------------------------------
plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java Lines 21 (patched) <https://reviews.apache.org/r/68211/#comment292427> I am getting below PMD violations. Could you please take a look? ``` [INFO] --- maven-pmd-plugin:3.7:check (default) @ ranger-nifi-registry-plugin --- [INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:21 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package. [INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:22 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package. [INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:23 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package. [INFO] PMD Failure: org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java:24 Rule:ImportFromSamePackage Priority:3 No need to import a type that lives in the same package. ``` - Velmurugan Periasamy On Sept. 3, 2018, 12:09 a.m., ijokaruma...@gmail.com Koji wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68211/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2018, 12:09 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2157 > https://issues.apache.org/jira/browse/RANGER-2157 > > > Repository: ranger > > > Description > ------- > > Adding NiFi Registry service. NiFi Registry is a sub-project of NiFi. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > 5e74da85a > > agents-common/src/main/resources/service-defs/ranger-servicedef-nifi-registry.json > PRE-CREATION > plugin-nifi-registry/.gitignore PRE-CREATION > plugin-nifi-registry/pom.xml PRE-CREATION > > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/RangerServiceNiFiRegistry.java > PRE-CREATION > > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryAuthType.java > PRE-CREATION > > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryClient.java > PRE-CREATION > > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConfigs.java > PRE-CREATION > > plugin-nifi-registry/src/main/java/org/apache/ranger/services/nifi/registry/client/NiFiRegistryConnectionMgr.java > PRE-CREATION > > plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryClient.java > PRE-CREATION > > plugin-nifi-registry/src/test/java/org/apache/ranger/services/nifi/registry/client/TestNiFiRegistryConnectionMgr.java > PRE-CREATION > plugin-nifi-registry/src/test/resources/resources-response.json > PRE-CREATION > pom.xml 472199d5d > src/main/assembly/admin-web.xml d0f354520 > > > Diff: https://reviews.apache.org/r/68211/diff/4/ > > > Testing > ------- > > Tested on local machine. > > In order to get NiFi Registry for integration tests, NiFi Registry needs to > be built manually as the change is not released at NiFi Registry project yet. > Please check [NiFi Registry Pull Request 131 for > NIFIREG-186](https://github.com/apache/nifi-registry/pull/131) to do so, > especially this > [README](https://github.com/apache/nifi-registry/blob/29239be99a5f6275060ecbdcb16ae9a8e7abef86/nifi-registry-extensions/nifi-registry-ranger-extension/README.md) > file should be a starting point. > > > Thanks, > > ijokaruma...@gmail.com Koji > >
