----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68843/#review209011 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java Line 22 (original), 22 (patched) <https://reviews.apache.org/r/68843/#comment293276> Please try not to use * in includes agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java Lines 260 (patched) <https://reviews.apache.org/r/68843/#comment293277> Please remove commented code agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java Lines 338 (patched) <https://reviews.apache.org/r/68843/#comment293278> As above security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java Line 354 (original), 359 (patched) <https://reviews.apache.org/r/68843/#comment293279> With additional code starting from line 350, can we remove this TODO comment? security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java Lines 863 (patched) <https://reviews.apache.org/r/68843/#comment293280> Is a check for xGroup being null (group not existing) required before de-referencing xGroup? - Abhay Kulkarni On Sept. 25, 2018, 10:05 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68843/ > ----------------------------------------------------------- > > (Updated Sept. 25, 2018, 10:05 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2218 > https://issues.apache.org/jira/browse/RANGER-2218 > > > Repository: ranger > > > Description > ------- > > Added validations for names during servicedef updates. Modified some of the > unit tests according to new changes. Also added validations to restrict > updates for username or groupname. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > d73210ee3 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > decf07cce > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b1ea280c9 > > > Diff: https://reviews.apache.org/r/68843/diff/2/ > > > Testing > ------- > > 1. Tested running curl calls to update existing service def. > 2. Verfied all the exsting unit tests ran successfully. > > > Thanks, > > Sailaja Polavarapu > >
