----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68843/#review209046 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On Sept. 26, 2018, 5:16 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68843/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 5:16 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2218 > https://issues.apache.org/jira/browse/RANGER-2218 > > > Repository: ranger > > > Description > ------- > > Added validations for names during servicedef updates. Modified some of the > unit tests according to new changes. Also added validations to restrict > updates for username or groupname. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerServiceDefValidator.java > d73210ee3 > > agents-common/src/test/java/org/apache/ranger/plugin/model/validation/TestRangerServiceDefValidator.java > decf07cce > security-admin/src/main/java/org/apache/ranger/biz/XUserMgr.java b1ea280c9 > > > Diff: https://reviews.apache.org/r/68843/diff/3/ > > > Testing > ------- > > 1. Tested running curl calls to update existing service def. > 2. Verfied all the exsting unit tests ran successfully. > > > Thanks, > > Sailaja Polavarapu > >
