-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68770/
-----------------------------------------------------------
(Updated Oct. 4, 2018, 7:50 p.m.)
Review request for ranger.
Changes
-------
Moved npm-related files to src/main/webapp as per review comments. Changed
maven-frontend-plugin working directory to security-admin/target.
Bugs: RANGER-2220
https://issues.apache.org/jira/browse/RANGER-2220
Repository: ranger
Description
-------
Maven build modified so that the admin UI JavaScript resources are
concatenated/compressed using the RequireJS Optimizer.
During the packaging phase index.html is rewritten so that it loads the
compressed JS file instead of the JS source tree.
Diffs (updated)
-----
pom.xml d8e3a5da9
security-admin/pom.xml 84bbd6650
security-admin/src/main/webapp/index.html 60ef5a75b
security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js
276175505
security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js
6cd05b03d
security-admin/src/main/webapp/minify.build.js PRE-CREATION
security-admin/src/main/webapp/package-lock.json PRE-CREATION
security-admin/src/main/webapp/package.json PRE-CREATION
security-admin/src/main/webapp/scripts/Init.js 4493f62e0
security-admin/src/main/webapp/scripts/Main.js d518afbf2
Diff: https://reviews.apache.org/r/68770/diff/4/
Changes: https://reviews.apache.org/r/68770/diff/3-4/
Testing
-------
Performed:
mvn package -pl security-admin -am
cd security-admin/
cd security-admin/target/security-admin-web-2.0.0-SNAPSHOT
http-server
# opened http://localhost:8080 and inspected browser network tab and console:
# network tab lists only 26 requests
# console contains no packaging related errors (it contains 4 errors due to
missing backend service)
Thanks,
Csaba Koncz
