----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70340/#review214241 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java Lines 155 (patched) <https://reviews.apache.org/r/70340/#comment300437> In PaaS environment (like Amazon EC2), this may not work. Also, it may be sometimes expensive to do a name lookup. For a more detailed explanation please take a look at https://stackoverflow.com/a/40702767. Please explore using JNI/JNA solution as outlined here. (https://github.com/mattsheppard/gethostname4j) agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java Lines 161 (patched) <https://reviews.apache.org/r/70340/#comment300440> As this API is called for each access evaluation, please consider caching the hostname to avoid overhead for each call, either here or from where it is called (policy-engine and hive authorizer?) - Abhay Kulkarni On April 1, 2019, 2:43 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70340/ > ----------------------------------------------------------- > > (Updated April 1, 2019, 2:43 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2382 > https://issues.apache.org/jira/browse/RANGER-2382 > > > Repository: ranger > > > Description > ------- > > In Audit Page > > Access tab: > Add ‘agentHostname’ column to audit log table, which records > IP-address/hostname of the plugin. Having this field in audit UI can avoid > having to scan all the hosts. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > 80a6d9e > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > ee95800 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 4421442 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > b82ff29 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 9fe0531 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > 65f5c01 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > be82639 > security-admin/contrib/solr_for_audit_setup/conf/managed-schema c33f6de > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java ce577e0 > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > 6687b19 > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > cf2a3b4 > security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java > 7b63a63 > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > d4d87d7 > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js e7b45d9 > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > ef149d5 > > > Diff: https://reviews.apache.org/r/70340/diff/1/ > > > Testing > ------- > > 1)verified if ‘agentHostname’ is getting added in solr and also getting > displayed on Ranger UI -access audit page. > 2)verified agentHostName shows destination of agents. > > > Thanks, > > Nikhil P > >
