----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70340/#review214284 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java Lines 127 (patched) <https://reviews.apache.org/r/70340/#comment300499> Instead of relying on accessResult providing the hostname, please consider getting agentHostName here as this is the only place it is needed. This will lead to better encapsulation and no changes to RangerPolicyEngineImpl, RangerHiveAuthorizer, RangerAccessResult classes. - Abhay Kulkarni On April 2, 2019, 12:26 p.m., Nikhil P wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70340/ > ----------------------------------------------------------- > > (Updated April 2, 2019, 12:26 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Pradeep Agrawal, Ramesh Mani, Selvamohan Neethiraj, Sailaja Polavarapu, and > Velmurugan Periasamy. > > > Bugs: RANGER-2382 > https://issues.apache.org/jira/browse/RANGER-2382 > > > Repository: ranger > > > Description > ------- > > In Audit Page > > Access tab: > Add ‘agentHostname’ column to audit log table, which records > IP-address/hostname of the plugin. Having this field in audit UI can avoid > having to scan all the hosts. > > > Diffs > ----- > > > agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java > 80a6d9e7b > > agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java > ee95800c1 > agents-common/pom.xml 4486af359 > > agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java > 4421442ab > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java > b82ff29f6 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 5e10e0d33 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java > 65f5c017f > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > be8263911 > security-admin/contrib/solr_for_audit_setup/conf/managed-schema c33f6de06 > security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java > ce577e0fc > > security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java > 6687b198c > > security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java > cf2a3b4d8 > security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java > 7b63a6328 > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > d4d87d7d8 > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js > e7b45d992 > security-admin/src/test/java/org/apache/ranger/rest/TestAssetREST.java > ef149d5fa > > > Diff: https://reviews.apache.org/r/70340/diff/2/ > > > Testing > ------- > > 1)verified if ‘agentHostname’ is getting added in solr and also getting > displayed on Ranger UI -access audit page. > 2)verified agentHostName shows destination of agents. > > > Thanks, > > Nikhil P > >
