> On April 15, 2019, 11:41 p.m., Abhay Kulkarni wrote: > > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > > Line 36 (original), 37 (patched) > > <https://reviews.apache.org/r/70394/diff/3-4/?file=2138877#file2138877line37> > > > > mandatory still needs to be true. Otherwise, policy validation code > > will allow creation of policy such as > > {catalog:catalog-1;schema:null;table=table-1}.
Gotcha. So how do I set a policy on *just* the catalog and not all its schemas? > On April 15, 2019, 11:41 p.m., Abhay Kulkarni wrote: > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > > Line 403 (original), 397 (patched) > > <https://reviews.apache.org/r/70394/diff/3-4/?file=2138886#file2138886line403> > > > > It is better not to set the value of a resource-definition in > > RangerPestoResource map, if the value is null. > > > > if (schema.isPresent() { > > setValue(KEY_SCHEMA, schema.get(); > > } > > > > Please review similar usage pattern elsewhere too. Mmm, okay. The result is the same for the map and imho its more readable and explicit. - Bolke ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70394/#review214676 ----------------------------------------------------------- On April 14, 2019, 12:42 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70394/ > ----------------------------------------------------------- > > (Updated April 14, 2019, 12:42 p.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-2395 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2395 > > > Repository: ranger > > > Description > ------- > > Presto Plugin for Ranger. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh b4194a736 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > cbfd649c9 > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > PRE-CREATION > plugin-presto/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-presto/conf/ranger-presto-audit-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-presto-audit.xml PRE-CREATION > plugin-presto/conf/ranger-presto-security-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-presto-security.xml PRE-CREATION > plugin-presto/pom.xml PRE-CREATION > plugin-presto/scripts/install.properties PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > PRE-CREATION > pom.xml 2a45f8b2d > ranger-presto-plugin-shim/pom.xml PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin > PRE-CREATION > src/main/assembly/admin-web.xml 06ba8c4f0 > src/main/assembly/plugin-presto.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/70394/diff/4/ > > > Testing > ------- > > Tested in production. > > https://issues.apache.org/jira/browse/RANGER-2395 > > > Thanks, > > Bolke de Bruin > >
