----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/70394/#review215006 -----------------------------------------------------------
pom.xml Line 180 (original), 181 (patched) <https://reviews.apache.org/r/70394/#comment301299> could you please update the patch? ``` $ git apply --check -v ~/Downloads/0001-Add-Presto-plugin.patch Checking patch agents-common/scripts/enable-agent.sh... Checking patch agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java... Checking patch agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json... Checking patch plugin-presto/conf/ranger-policymgr-ssl-changes.cfg... Checking patch plugin-presto/conf/ranger-policymgr-ssl.xml... Checking patch plugin-presto/conf/ranger-presto-audit-changes.cfg... Checking patch plugin-presto/conf/ranger-presto-audit.xml... Checking patch plugin-presto/conf/ranger-presto-security-changes.cfg... Checking patch plugin-presto/conf/ranger-presto-security.xml... Checking patch plugin-presto/pom.xml... Checking patch plugin-presto/scripts/install.properties... Checking patch plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java... Checking patch plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java... Checking patch plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java... Checking patch plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java... Checking patch plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java... Checking patch pom.xml... error: while searching for: <codehaus.woodstox.stax2api.version>3.1.4</codehaus.woodstox.stax2api.version> <fasterxml.woodstox.version>5.0.3</fasterxml.woodstox.version> <fasterxml.jackson.version>2.9.8</fasterxml.jackson.version> </properties> <profiles> <profile> error: patch failed: pom.xml:181 error: pom.xml: patch does not apply Checking patch ranger-presto-plugin-shim/pom.xml... Checking patch ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java... Checking patch ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java... Checking patch ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java... Checking patch ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java... Checking patch ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin... Checking patch src/main/assembly/admin-web.xml... Hunk #1 succeeded at 403 (offset 3 lines). Checking patch src/main/assembly/plugin-presto.xml... ``` - Velmurugan Periasamy On April 18, 2019, 7:04 p.m., Bolke de Bruin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/70394/ > ----------------------------------------------------------- > > (Updated April 18, 2019, 7:04 p.m.) > > > Review request for ranger and Abhay Kulkarni. > > > Bugs: https://issues.apache.org/jira/browse/RANGER-2395 > > https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/RANGER-2395 > > > Repository: ranger > > > Description > ------- > > Presto Plugin for Ranger. > > > Diffs > ----- > > agents-common/scripts/enable-agent.sh b4194a736 > > agents-common/src/main/java/org/apache/ranger/plugin/store/EmbeddedServiceDefsUtil.java > cbfd649c9 > agents-common/src/main/resources/service-defs/ranger-servicedef-presto.json > PRE-CREATION > plugin-presto/conf/ranger-policymgr-ssl-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-policymgr-ssl.xml PRE-CREATION > plugin-presto/conf/ranger-presto-audit-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-presto-audit.xml PRE-CREATION > plugin-presto/conf/ranger-presto-security-changes.cfg PRE-CREATION > plugin-presto/conf/ranger-presto-security.xml PRE-CREATION > plugin-presto/pom.xml PRE-CREATION > plugin-presto/scripts/install.properties PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/RangerServicePresto.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoClient.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoConnectionManager.java > PRE-CREATION > > plugin-presto/src/main/java/org/apache/ranger/services/presto/client/PrestoResourceManager.java > PRE-CREATION > pom.xml 2a45f8b2d > ranger-presto-plugin-shim/pom.xml PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/PrestoRangerPlugin.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerConfig.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControl.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/java/org/apache/ranger/authorization/presto/authorizer/RangerSystemAccessControlFactory.java > PRE-CREATION > > ranger-presto-plugin-shim/src/main/resources/META-INF/services/io.prestosql.spi.Plugin > PRE-CREATION > src/main/assembly/admin-web.xml 06ba8c4f0 > src/main/assembly/plugin-presto.xml PRE-CREATION > > > Diff: https://reviews.apache.org/r/70394/diff/6/ > > > Testing > ------- > > Tested in production. > > https://issues.apache.org/jira/browse/RANGER-2395 > > > Thanks, > > Bolke de Bruin > >
