----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71007/#review216351 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java Lines 95 (patched) <https://reviews.apache.org/r/71007/#comment303544> Consider returning a single return for clarify. ArrayList<Long> ret = new ArrayList<Long>(); if (serviceId != null) { try { ret = getEntityManager() .createNamedQuery("XXPolicy.findPolicyIdsByServiceId", Long.class) .setParameter("serviceId", serviceId).getResultList(); } catch (NoResultException e) { // } } return ret; - Ramesh Mani On July 3, 2019, 3:39 p.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71007/ > ----------------------------------------------------------- > > (Updated July 3, 2019, 3:39 p.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh > Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2493 > https://issues.apache.org/jira/browse/RANGER-2493 > > > Repository: ranger > > > Description > ------- > > ** Problem Statement ** Ranger takes an extremely long time to override a > service with many policies, will crash ranger if admin JVM heap size is the 1 > GB default > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > bf50df3a8 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 51c0de56c > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > baf6b6ea4 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 171d73bfa > security-admin/src/main/resources/META-INF/jpa_named_queries.xml eb0384b14 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > dc845cf80 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 9b9aa8377 > > > Diff: https://reviews.apache.org/r/71007/diff/1/ > > > Testing > ------- > > Tested 500 policy import json and unable to reproduce JVM issue. > > > Thanks, > > Pradeep Agrawal > >
