----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71007/#review216504 -----------------------------------------------------------
Ship it! Ship It! - Abhay Kulkarni On July 9, 2019, 8:40 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71007/ > ----------------------------------------------------------- > > (Updated July 9, 2019, 8:40 a.m.) > > > Review request for ranger, Ankita Sinha, bhavik patel, Gautam Borad, Abhay > Kulkarni, Madhan Neethiraj, Mehul Parikh, Nikhil P, Nitin Galave, Ramesh > Mani, Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2493 > https://issues.apache.org/jira/browse/RANGER-2493 > > > Repository: ranger > > > Description > ------- > > ** Problem Statement ** Ranger takes an extremely long time to delete a > service with many policies, will crash ranger if admin JVM heap size is the 1 > GB default > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 055cd382b > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 0effa6789 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > bf50df3a8 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > 51c0de56c > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > baf6b6ea4 > > security-admin/src/main/java/org/apache/ranger/patch/PatchForUpdatingPolicyJson_J10019.java > 1a1cc23bd > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 171d73bfa > > security-admin/src/main/java/org/apache/ranger/service/RangerBaseModelService.java > b16bfe7b3 > > security-admin/src/main/java/org/apache/ranger/service/RangerDataHistService.java > 7bd0681b1 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml eb0384b14 > security-admin/src/test/java/org/apache/ranger/biz/TestServiceDBStore.java > dc845cf80 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 9b9aa8377 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerDataHistService.java > 65e273c4e > > > Diff: https://reviews.apache.org/r/71007/diff/4/ > > > Testing > ------- > > Tested with deleting a service having 2000 policies and unable to reproduce > JVM issue. > Tested with importing policy json having 2000 policies and override option. > 500 policies deletion took 100 seconds while 1000 policies deletion took 4 > minutes. > > > Thanks, > > Pradeep Agrawal > >
