----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71015/#review216399 -----------------------------------------------------------
embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java Lines 99 (patched) <https://reviews.apache.org/r/71015/#comment303618> Please rename this SSLEnabled => isSSLEnabled embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java Lines 172 (patched) <https://reviews.apache.org/r/71015/#comment303619> SSLEnabledProp => sslEnabledProp embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java Lines 173 (patched) <https://reviews.apache.org/r/71015/#comment303617> consider replacing this with isSSLEnabled = ("true".equalsIgnoreCase(sslEnabledProp); embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java Lines 316 (patched) <https://reviews.apache.org/r/71015/#comment303620> Please consider rewriting this like String uploadConfigsUrl = "http://"; + baseUrl.toString() + "/admin/configs?action=UPLOAD&name="; if (isSSLEnabled) { uploadConfigsUrl = "https://"; + baseUrl.toString() + "/admin/configs?action=UPLOAD&name="; } - Ramesh Mani On July 5, 2019, 6:19 a.m., Fatima Khan wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71015/ > ----------------------------------------------------------- > > (Updated July 5, 2019, 6:19 a.m.) > > > Review request for ranger, Gautam Borad, Kevin Risden, Oliver Szabo, Pradeep > Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2490 > https://issues.apache.org/jira/browse/RANGER-2490 > > > Repository: ranger > > > Description > ------- > > Add https support while using Solr API to upload config set > > > Diffs > ----- > > > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java > 02a3f6c > > > Diff: https://reviews.apache.org/r/71015/diff/1/ > > > Testing > ------- > > Tested Below Scenario in Ranger with https support > 1.Solr configuration were uploaded successfully > 2.Solr collections were created successfully > > > Thanks, > > Fatima Khan > >
