> On July 8, 2019, noon, Oliver Szabo wrote:
> > embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java
> > Line 309 (original), 313 (patched)
> > <https://reviews.apache.org/r/71015/diff/2/?file=2153883#file2153883line313>
> >
> > instead of concat strings multiple times you can do something like
> > (with including the config name as well):
> >
> > ```java
> > String protocol = "https" ? isSSLEnabled : "http"
> > String uploadConfigsUrl =
> > String.format("%s://%s//admin/configs?action=UPLOAD&name=%s", protocol,
> > baseUrl.toString(), solr_config_name)
> > ```
Did u mean this
String protocol = isSSLEnabled ? "https": "http";
String uploadConfigsUrl =
String.format("%s://%s/admin/configs?action=UPLOAD&name=", protocol,
baseUrl.toString());
- Fatima
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71015/#review216415
-----------------------------------------------------------
On July 8, 2019, 6:51 a.m., Fatima Khan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71015/
> -----------------------------------------------------------
>
> (Updated July 8, 2019, 6:51 a.m.)
>
>
> Review request for ranger, Gautam Borad, Kevin Risden, Oliver Szabo, Pradeep
> Agrawal, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-2490
> https://issues.apache.org/jira/browse/RANGER-2490
>
>
> Repository: ranger
>
>
> Description
> -------
>
> Add https support while using Solr API to upload config set
>
>
> Diffs
> -----
>
>
> embeddedwebserver/src/main/java/org/apache/ranger/server/tomcat/SolrCollectionBootstrapper.java
> 02a3f6c
>
>
> Diff: https://reviews.apache.org/r/71015/diff/2/
>
>
> Testing
> -------
>
> Tested Below Scenario in Ranger with https support
> 1.Solr configuration were uploaded successfully
> 2.Solr collections were created successfully
>
>
> Thanks,
>
> Fatima Khan
>
>
