----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71049/#review216508 -----------------------------------------------------------
Fix it, then Ship it! security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 4054 (patched) <https://reviews.apache.org/r/71049/#comment303730> Log at #4059 is repeated at line #4067 as well. Consider removing #4054 - #4056. - Madhan Neethiraj On July 10, 2019, 11:15 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71049/ > ----------------------------------------------------------- > > (Updated July 10, 2019, 11:15 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2481 > https://issues.apache.org/jira/browse/RANGER-2481 > > > Repository: ranger > > > Description > ------- > > Fixed timing related issues when creating multiple services simultaneously. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 171d73bfa > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java > 0335e6d48 > > security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java > c60773e71 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 9b9aa8377 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerTransactionService.java > 9ba9cf119 > > > Diff: https://reviews.apache.org/r/71049/diff/1/ > > > Testing > ------- > > Ran multiple curl commands each creating a different resource service > concurrently. Ensured that the services are created, a single tag service is > created, and is linked to each of the created resource services. > > > Thanks, > > Abhay Kulkarni > >
