----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71049/#review216537 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Line 78 (original), 78 (patched) <https://reviews.apache.org/r/71049/#comment303749> Could you please check and update the patch? ``` $ git apply --check -v ~/Downloads/0001-RANGER-2481-Create-a-tag-service-when-a-resource-ser.patch Checking patch security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java... error: while searching for: import org.apache.ranger.common.RangerValidatorFactory; import org.apache.ranger.common.ServiceUtil; import org.apache.ranger.common.UserSessionBase; import org.apache.ranger.db.RangerDaoManager; import org.apache.ranger.entity.XXPolicyExportAudit; import org.apache.ranger.entity.XXSecurityZone; error: patch failed: security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java:78 error: security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java: patch does not apply Checking patch security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java... error: while searching for: if (LOG.isDebugEnabled()) { LOG.debug("Using separate thread for committing work [pluginActivityAuditCommitInline:" + pluginActivityAuditCommitInline + "]"); } transactionService.executeAfterTransactionComplete(commitWork); } } error: patch failed: security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java:61 error: security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java: patch does not apply Checking patch security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java... error: while searching for: } } public void executeAfterTransactionComplete(final Runnable task) { try { scheduler.schedule(new Runnable() { @Override error: patch failed: security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java:72 error: security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java: patch does not apply Checking patch security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java... error: while searching for: import org.apache.ranger.common.ServiceUtil; import org.apache.ranger.common.StringUtil; import org.apache.ranger.common.UserSessionBase; import org.apache.ranger.db.RangerDaoManager; import org.apache.ranger.db.XXSecurityZoneDao; import org.apache.ranger.db.XXSecurityZoneRefServiceDao; error: patch failed: security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java:52 error: security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java: patch does not apply Checking patch security-admin/src/test/java/org/apache/ranger/service/TestRangerTransactionService.java... error: while searching for: @Test public void test3ExecuteAfterTransactionComplete() { rangerTransactionService.executeAfterTransactionComplete(task); } } error: patch failed: security-admin/src/test/java/org/apache/ranger/service/TestRangerTransactionService.java:55 error: security-admin/src/test/java/org/apache/ranger/service/TestRangerTransactionService.java: patch does not apply ``` - Velmurugan Periasamy On July 11, 2019, 12:23 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71049/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 12:23 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2481 > https://issues.apache.org/jira/browse/RANGER-2481 > > > Repository: ranger > > > Description > ------- > > Fixed timing related issues when creating multiple services simultaneously. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 171d73bfa > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginActivityLogger.java > 0335e6d48 > > security-admin/src/main/java/org/apache/ranger/service/RangerTransactionService.java > c60773e71 > security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java > 9b9aa8377 > > security-admin/src/test/java/org/apache/ranger/service/TestRangerTransactionService.java > 9ba9cf119 > > > Diff: https://reviews.apache.org/r/71049/diff/2/ > > > Testing > ------- > > Ran multiple curl commands each creating a different resource service > concurrently. Ensured that the services are created, a single tag service is > created, and is linked to each of the created resource services. > > > Thanks, > > Abhay Kulkarni > >
