----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71057/#review216528 -----------------------------------------------------------
Fix it, then Ship it! UI updates look good. security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java Lines 158 (patched) <https://reviews.apache.org/r/71057/#comment303747> It will be efficient to have a named-query to return serviceType, for the given serviceName; this will avoid having to retrieve XXService and build RangerService object. In deployments having large number of plugins, this can improve the response time significantly. Same for line #189 as well. - Madhan Neethiraj On July 11, 2019, 1:08 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71057/ > ----------------------------------------------------------- > > (Updated July 11, 2019, 1:08 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2498 > https://issues.apache.org/jira/browse/RANGER-2498 > > > Repository: ranger > > > Description > ------- > > 1) Enable client sorting on all columns . > 2) Add timestamp for active, last update and download column like (2:43 hours > ago), (1 day, 15:26 hours ago), (15 minutes ago). > 3) Add Service Type column and also add it in the search filter. > 4) Change Initial Service Type column to Application type. > 5) Remove pagination in Plugin status tab (show all records without > pagination). > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java > 11c3a99 > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java > 2bbf0d4 > security-admin/src/main/webapp/scripts/collections/XABaseCollection.js > aeab19e > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 44d7dc7 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 22cdc83 > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js def5e22 > > > Diff: https://reviews.apache.org/r/71057/diff/1/ > > > Testing > ------- > > 1.Checked service details are getting sorted in acending and decending > 2.Checked Service Type column is changed to Application type > 3.Checked pagination on different pages > 4.Checked it is showing correct time for active, last update and download > column. > > > Thanks, > > Nitin Galave > >
