----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71114/#review216721 -----------------------------------------------------------
agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java Line 73 (original), 74 (patched) <https://reviews.apache.org/r/71114/#comment303910> To avoid breaking use of existing constructor, consider retaining existing version and add a new constructor that takes 'clusterName' parameter. Like: // existing constructor; simply calls the new one with clusterName=null public RangerPluginInfo(Long id, Date createTime, Date updateTime, String serviceName, String appType, String hostName, String ipAddress, Map<String, String> info) { this(id, createTime, updateTime, serviceName, appType, hostname, ipAddress, null, Map<String, String> info); } // new constructor public RangerPluginInfo(Long id, Date createTime, Date updateTime, String serviceName, String appType, String hostName, String ipAddress, String clusterName, Map<String, String> info) { super(); ... } security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java Lines 800 (patched) <https://reviews.apache.org/r/71114/#comment303911> dbObj.getClusterName() can be null here - looking at conditions in 'if' block at #792. Consider replacing #800 with: if (!StringUtils.equals(dbObj.getClusterName(),pluginInfo.getClusterName())) { Please review and update other such usage as well. - Madhan Neethiraj On July 18, 2019, 9:10 a.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71114/ > ----------------------------------------------------------- > > (Updated July 18, 2019, 9:10 a.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2506 > https://issues.apache.org/jira/browse/RANGER-2506 > > > Repository: ranger > > > Description > ------- > > Add cluster name on plugin status tab. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java > e3f9f15 > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 7e672c3 > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql a6b033a > > security-admin/db/mysql/patches/039-add-column-version-in-x_policy_export_audit.sql > b9dd306 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > a4439d2 > > security-admin/db/oracle/patches/039-add-column-version-in-x_policy_export_audit.sql > 63bb333 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 2d5a891 > > security-admin/db/postgres/patches/039-add-column-version-in-x_policy_export_audit.sql > 3177d5a > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > f2e2840 > > security-admin/db/sqlanywhere/patches/039-add-column-version-in-x_policy_export_audit.sql > 310a63a > security-admin/db/sqlserver/optimized/current/ranger_core_db_sqlserver.sql > be1e8a3 > > security-admin/db/sqlserver/patches/039-add-column-version-in-x_policy_export_audit.sql > f9ce950 > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java f5fce93 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > fc57601 > security-admin/src/main/java/org/apache/ranger/entity/XXPluginInfo.java > 7b07bfc > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 3f6b7e1 > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java e650968 > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java > 3ca3b8f > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f7237fd > security-admin/src/test/java/org/apache/ranger/rest/TestTagREST.java > 90060b2 > > > Diff: https://reviews.apache.org/r/71114/diff/1/ > > > Testing > ------- > > Cluster Name is getting displayed on Audit>>plugin status tab. > Checked Cluster Name Search Filtering on Audit>>plugin status tab. > > > Thanks, > > Mateen Mansoori > >
