> On July 18, 2019, 12:51 p.m., Madhan Neethiraj wrote: > > agents-common/src/main/java/org/apache/ranger/plugin/model/RangerPluginInfo.java > > Line 73 (original), 74 (patched) > > <https://reviews.apache.org/r/71114/diff/1/?file=2156126#file2156126line74> > > > > To avoid breaking use of existing constructor, consider retaining > > existing version and add a new constructor that takes 'clusterName' > > parameter. Like: > > > > // existing constructor; simply calls the new one with > > clusterName=null > > public RangerPluginInfo(Long id, Date createTime, Date updateTime, > > String serviceName, String appType, String hostName, String ipAddress, > > Map<String, String> info) { > > this(id, createTime, updateTime, serviceName, appType, hostname, > > ipAddress, null, Map<String, String> info); > > } > > > > // new constructor > > public RangerPluginInfo(Long id, Date createTime, Date updateTime, > > String serviceName, String appType, String hostName, String ipAddress, > > String clusterName, Map<String, String> info) { > > super(); > > > > ... > > }
Hi, Madhan Now instead of adding new column in db, using existing info column which store json string, so now this constructor not in use for the current patch. - Mateen ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71114/#review216721 ----------------------------------------------------------- On July 25, 2019, 12:37 p.m., Mateen Mansoori wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71114/ > ----------------------------------------------------------- > > (Updated July 25, 2019, 12:37 p.m.) > > > Review request for ranger, Gautam Borad, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Nikhil P, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2506 > https://issues.apache.org/jira/browse/RANGER-2506 > > > Repository: ranger > > > Description > ------- > > Add cluster name on plugin status tab. > > > Diffs > ----- > > agents-common/src/main/java/org/apache/ranger/plugin/util/SearchFilter.java > 7e672c3 > security-admin/src/main/java/org/apache/ranger/biz/AssetMgr.java f5fce93 > security-admin/src/main/java/org/apache/ranger/common/RangerSearchUtil.java > fc57601 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 990fc2b > security-admin/src/main/java/org/apache/ranger/rest/TagREST.java e650968 > > security-admin/src/main/java/org/apache/ranger/service/RangerPluginInfoService.java > 3ca3b8f > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js f7237fd > > > Diff: https://reviews.apache.org/r/71114/diff/2/ > > > Testing > ------- > > Cluster Name is getting displayed on Audit>>plugin status tab. > Checked Cluster Name Search Filtering on Audit>>plugin status tab. > > > Thanks, > > Mateen Mansoori > >
