-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71322/#review217331
-----------------------------------------------------------


Fix it, then Ship it!





hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java
Lines 196 (patched)
<https://reviews.apache.org/r/71322/#comment304630>

    Consider replacing '*' with WILDCARD_ASTERISK - in line #196, #197, #228, 
#229.



hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java
Lines 206 (patched)
<https://reviews.apache.org/r/71322/#comment304631>

    Is it necessary to grant 'select' access to 'public' on all tables in 
default db? This will allow everyone to be able to perform 'select' on every 
table in default db. If line #206 is removed, only owner of the table will be 
allowed to perform 'select' (and all other operations).


- Madhan Neethiraj


On Aug. 20, 2019, 8:23 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/71322/
> -----------------------------------------------------------
> 
> (Updated Aug. 20, 2019, 8:23 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, 
> Madhan Neethiraj, Pradeep Agrawal, Selvamohan Neethiraj, Sailaja Polavarapu, 
> and Velmurugan Periasamy.
> 
> 
> Bugs: RANGER-2539
>     https://issues.apache.org/jira/browse/RANGER-2539
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-2539:Create Default Policies for Hive Databases -default, 
> Information_schema
> 
> 
> Diffs
> -----
> 
>   
> hive-agent/src/main/java/org/apache/ranger/services/hive/RangerServiceHive.java
>  89b8100 
> 
> 
> Diff: https://reviews.apache.org/r/71322/diff/3/
> 
> 
> Testing
> -------
> 
> Testing in local vm by create a hive service.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to