----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71552/#review218016 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java Lines 2181 (patched) <https://reviews.apache.org/r/71552/#comment305482> Getting compilation error : [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.3:compile (default-compile) on project security-admin-web: Compilation failure [ERROR] /Users/mehul/Workspace/XaSecure/ranger/security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java:[2181,9] error: policyExists(Long) in ServiceDBStore cannot implement policyExists(Long) in ServiceStore - Mehul Parikh On Sept. 29, 2019, 1:03 a.m., Andrew Luo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71552/ > ----------------------------------------------------------- > > (Updated Sept. 29, 2019, 1:03 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2594 > https://issues.apache.org/jira/browse/RANGER-2594 > > > Repository: ranger > > > Description > ------- > > Deletion of large policies (those with several thousand users or resources) > is slow - one reason for this is that we fetch the entire policy during > validation, when we only need to check if the policy exists or not. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerPolicyValidator.java > a85410782 > > agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerValidator.java > f31483e97 > > agents-common/src/main/java/org/apache/ranger/plugin/store/ServiceStore.java > ba7407fc4 > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 85db57719 > > > Diff: https://reviews.apache.org/r/71552/diff/1/ > > > Testing > ------- > > Unit tests, and tested end-to-end > > > Thanks, > > Andrew Luo > >
