> On Oct. 14, 2019, 6:55 a.m., Mehul Parikh wrote: > > security-admin/src/main/resources/META-INF/jpa_named_queries.xml > > Lines 1588 (patched) > > <https://reviews.apache.org/r/71554/diff/1/?file=2167369#file2167369line1588> > > > > @Andrew Luo - patch fails to apply, can you please rebase your patch on > > latest master?
Thanks for the review, I've fixed this. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71554/#review218197 ----------------------------------------------------------- On Oct. 17, 2019, 5:02 a.m., Andrew Luo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71554/ > ----------------------------------------------------------- > > (Updated Oct. 17, 2019, 5:02 a.m.) > > > Review request for ranger. > > > Bugs: RANGER-2595 > https://issues.apache.org/jira/browse/RANGER-2595 > > > Repository: ranger > > > Description > ------- > > Policy deletion is slow for policies that have a large number of users or > resources. This patch uses batch SQL deletion to speed up deletion. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 055cd382b > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefAccessTypeDao.java > 1ef01bb28 > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefConditionDao.java > 2c04ab483 > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefDataMaskTypeDao.java > 258e3b0ba > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefGroupDao.java > 08829d4f7 > > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefResourceDao.java > e259ee864 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefRoleDao.java > b92f8066f > security-admin/src/main/java/org/apache/ranger/db/XXPolicyRefUserDao.java > f7b6131c6 > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 7e2139916 > > > Diff: https://reviews.apache.org/r/71554/diff/2/ > > > Testing > ------- > > Tested manually, ran build/tests > > > Thanks, > > Andrew Luo > >
