> On Oct. 30, 2019, 9:39 p.m., Sailaja Polavarapu wrote: > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java > > Lines 47 (patched) > > <https://reviews.apache.org/r/71693/diff/1/?file=2170648#file2170648line47> > > > > Please add show current roles command as well.
HiveOperationType does have show current roles as now. I shall raise a bug to hive to take care of this. Once its done we can fix this issue. > On Oct. 30, 2019, 9:39 p.m., Sailaja Polavarapu wrote: > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > > Lines 106 (patched) > > <https://reviews.apache.org/r/71693/diff/1/?file=2170649#file2170649line106> > > > > Similarly show role grant command is also supported for group and role. > > > > SHOW ROLE GRANT (USER|GROUP|ROLE) principal_name; show role grant is not implemented yet in Ranger. I shall take care of this in separate patch. - Ramesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71693/#review218464 ----------------------------------------------------------- On Nov. 7, 2019, 6:45 a.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71693/ > ----------------------------------------------------------- > > (Updated Nov. 7, 2019, 6:45 a.m.) > > > Review request for ranger, Don Bosco Durai, Gautam Borad, Abhay Kulkarni, > Madhan Neethiraj, Mehul Parikh, Pradeep Agrawal, Selvamohan Neethiraj, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-2631 > https://issues.apache.org/jira/browse/RANGER-2631 > > > Repository: ranger > > > Description > ------- > > RANGER-2631: Ranger Audit logs for for SHOW commands related to ROLE > operations in Hive > > > Diffs > ----- > > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuditHandler.java > 765da59 > > hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java > f10bde4 > > > Diff: https://reviews.apache.org/r/71693/diff/2/ > > > Testing > ------- > > Testing done by executing following hive commands > CREATE ROLE, DROP ROLE, SHOW ROLES, SHOW PRINCIPAL <role>, GRANT ROLE, REVOKE > ROLE, SHOW CURRENT ROLE > > > Thanks, > > Ramesh Mani > >
