> On Nov. 11, 2019, 2:22 a.m., Don Bosco Durai wrote: > > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > > Lines 46 (patched) > > <https://reviews.apache.org/r/71746/diff/1/?file=2172004#file2172004line46> > > > > Should we take this value from propery? > > > > In RangerBizUtil, we already have a property for batchSize. But it > > might be better to create another one for this. E.g. bulkCreateBatchSize. > > > > Otherwise, code looks good. Thanks for your contribution
Fixed, thanks for the review. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71746/#review218592 ----------------------------------------------------------- On Nov. 16, 2019, 10:46 p.m., Andrew Luo wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71746/ > ----------------------------------------------------------- > > (Updated Nov. 16, 2019, 10:46 p.m.) > > > Review request for ranger. > > > Bugs: RANGER-2643 > https://issues.apache.org/jira/browse/RANGER-2643 > > > Repository: ranger > > > Description > ------- > > Policy creation is slow if the policy contains a large number of users or > resources. Part of the reason for this is that each row is a single > statement/transaction. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/PolicyRefUpdater.java > 7b2356bfd > security-admin/src/main/java/org/apache/ranger/biz/RangerBizUtil.java > 3761ef2ce > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 85289dd71 > security-admin/src/main/java/org/apache/ranger/common/db/BaseDao.java > bdd8fbbb6 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 54c9ee340 > security-admin/src/main/resources/META-INF/persistence.xml 211715978 > security-admin/src/main/resources/conf.dist/ranger-admin-default-site.xml > 99162971c > > > Diff: https://reviews.apache.org/r/71746/diff/2/ > > > Testing > ------- > > Compilation/end-to-end test of policy creation. > > > Thanks, > > Andrew Luo > >
