----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/71828/#review218807 -----------------------------------------------------------
Fix it, then Ship it! agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java Lines 161 (patched) <https://reviews.apache.org/r/71828/#comment306681> Given the test code in TestPolicyEngine is in the same package, consider marking this method as package-private, instead of public. agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java Lines 360 (patched) <https://reviews.apache.org/r/71828/#comment306680> Given the test code in TestPolicyEngine is in the same package, consider marking this method as package-private, instead of public. agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java Line 1407 (original), 1407 (patched) <https://reviews.apache.org/r/71828/#comment306679> Given the test code in TestPolicyEngine is in the same package, consider marking this method as package-private, instead of public. agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java Line 224 (original), 224 (patched) <https://reviews.apache.org/r/71828/#comment306682> Consider moving RangerResourceTrie to org.apache.ranger.plugin.policyengine package and mark all classes/methods needed by test code as package-private. - Madhan Neethiraj On Nov. 26, 2019, 11:24 p.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/71828/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2019, 11:24 p.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-2653 > https://issues.apache.org/jira/browse/RANGER-2653 > > > Repository: ranger > > > Description > ------- > > Ranger policy engine classes include some APIs that are only used and > required for testing. This ends up cluttering product code. Such APIs need to > be moved to utility class needed and used only as supporting test harness. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java > 75b0bf4d3 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java > 38b1c93a2 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java > 5709fd8a9 > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java > 3a78eab61 > > agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java > ea92e3cd4 > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java > b4c3060ef > > agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineComparison.java > 94ba8b90a > > > Diff: https://reviews.apache.org/r/71828/diff/1/ > > > Testing > ------- > > Passed all unit tests > > > Thanks, > > Abhay Kulkarni > >
