-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/71828/
-----------------------------------------------------------

(Updated Nov. 27, 2019, 3:11 a.m.)


Review request for ranger and Madhan Neethiraj.


Changes
-------

Addressed review comment


Bugs: RANGER-2653
    https://issues.apache.org/jira/browse/RANGER-2653


Repository: ranger


Description
-------

Ranger policy engine classes include some APIs that are only used and required 
for testing. This ends up cluttering product code. Such APIs need to be moved 
to utility class needed and used only as supporting test harness.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/contextenricher/RangerTagEnricher.java
 75b0bf4d3 
  
agents-common/src/main/java/org/apache/ranger/plugin/model/validation/RangerSecurityZoneValidator.java
 d89267620 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java
 38b1c93a2 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
 5709fd8a9 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyRepository.java
 3a78eab61 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerResourceTrie.java
 ea92e3cd4 
  
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngine.java
 b4c3060ef 
  
agents-common/src/test/java/org/apache/ranger/plugin/policyengine/TestPolicyEngineComparison.java
 94ba8b90a 


Diff: https://reviews.apache.org/r/71828/diff/3/

Changes: https://reviews.apache.org/r/71828/diff/2-3/


Testing
-------

Passed all unit tests


Thanks,

Abhay Kulkarni

Reply via email to