[
https://issues.apache.org/jira/browse/RANGER-2667?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Jiayi Liu updated RANGER-2667:
------------------------------
Description:
Running the disable-presto-plugin.sh script will always get stuck. Because the
script sets the
controlName to an empty string and passes it to the function
addOrUpdatePropertyToFile when disable the presto plugin. If controlName is an
empty string, addOrUpdatePropertyToFile will ignore this parameter and let fn
to be the second parameter. So $3 passed to checkPropertyInFile will be empty.
In checkPropertyInFile, if the second parameter is empty, the sed command will
never return, and the disable-presto-plugin.sh script will always get stuck.
We should pass the default value of access-control.name and set controlName to
be allow-all when disable presto plugin.
The default value of access-control.name can be seen here:
https://prestodb.io/docs/current/security/built-in-system-access-control.html
The pull request: https://github.com/apache/ranger/pull/45
was:
Running the disable-presto-plugin.sh script will always get stuck. Because the
script sets the
controlName to an empty string and passes it to the function
addOrUpdatePropertyToFile when disable the presto plugin. If controlName is an
empty string, addOrUpdatePropertyToFile will ignore this parameter and let fn
to be the second parameter. So $3 passed to checkPropertyInFile will be empty.
In checkPropertyInFile, if the second parameter is empty, the sed command will
never return, and the disable-presto-plugin.sh script will always get stuck.
We should pass the default value of access-control.name and set controlName to
be allow-all when disable presto plugin.
The pull request: https://github.com/apache/ranger/pull/45
> Running the disable-presto-plugin.sh script will always get stuck
> -----------------------------------------------------------------
>
> Key: RANGER-2667
> URL: https://issues.apache.org/jira/browse/RANGER-2667
> Project: Ranger
> Issue Type: Bug
> Components: plugins
> Affects Versions: 2.0.0
> Reporter: Jiayi Liu
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Running the disable-presto-plugin.sh script will always get stuck. Because
> the script sets the
> controlName to an empty string and passes it to the function
> addOrUpdatePropertyToFile when disable the presto plugin. If controlName is
> an empty string, addOrUpdatePropertyToFile will ignore this parameter and let
> fn to be the second parameter. So $3 passed to checkPropertyInFile will be
> empty. In checkPropertyInFile, if the second parameter is empty, the sed
> command will never return, and the disable-presto-plugin.sh script will
> always get stuck.
> We should pass the default value of access-control.name and set controlName
> to be allow-all when disable presto plugin.
> The default value of access-control.name can be seen here:
> https://prestodb.io/docs/current/security/built-in-system-access-control.html
> The pull request: https://github.com/apache/ranger/pull/45
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
