-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/72344/
-----------------------------------------------------------
Review request for ranger, Ankita Sinha, Dhaval Shah, Dineshkumar Yadav, Gautam
Borad, Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj,
Mehul Parikh, Nitin Galave, Nixon Rodrigues, Ramesh Mani, Sailaja Polavarapu,
and Velmurugan Periasamy.
Bugs: RANGER-2786
https://issues.apache.org/jira/browse/RANGER-2786
Repository: ranger
Description
-------
**Problem Statement:** Currently Ranger usersync group modifyTimestamp parsing
is in 12 hours format. (not sure its as per the requirement or by mistake). for
the parsing date format is choosen as "yyyyMMddhhmmss" where hh can convert
hour value to 12 hours format. for example: if a group is synced at 00:05am UTC
then this will highest user sync time stamp but after the conversion value
becomes 12:05 which is actually future timestamp and for the next 12 hours
delta sync of groups may not sync any groups.
**Proposed solution:** Conversion should be done in 24 hours format by using
hours in HH format rather hh.
**Note:**
1) To reproduce this issue frequently i have to switch my default ldap delta
sync interval to 5 minute as compare to 1 hour.
2) I am not sure about the current behaviour of different ldap servers and AD
without this patch. some might be working so i request reviewers to add their
feedback on this.
3) It will be better if reviewers can test this patch in their environment and
share their experiance here or on the jira.
Diffs
-----
ugsync/src/main/java/org/apache/ranger/ldapusersync/process/LdapDeltaUserGroupBuilder.java
3ff247005
Diff: https://reviews.apache.org/r/72344/diff/1/
Testing
-------
without this patch groups are not syncing if usersync is started one day ago
and group is created next day after 00:00 UTC
Tested this patch by creating ldap group around 00:05am UTC and wait for the
sync.
**Result:** Groups are syncing successfully with this patch.
Thanks,
Pradeep Agrawal
