> On July 21, 2020, 11:37 p.m., Abhay Kulkarni wrote: > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > > Line 113 (original) > > <https://reviews.apache.org/r/72700/diff/1/?file=2236123#file2236123line114> > > > > Can we keep this class variable and assign it a value in init()? Later > > the same auditHandler can be used whereever plugin.setResultProcessor() is > > called.
If I am using same auditHandler, I see ConcurrentModificationException and NPE in RangerSolrAuthorizer.authorize() --> RangerMultiResourceAuditHandler.flushAudit() call https://github.com/apache/ranger/blob/master/agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerMultiResourceAuditHandler.java#L53 - Sailaja ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72700/#review221302 ----------------------------------------------------------- On July 21, 2020, 10:51 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72700/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 10:51 p.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2922 > https://issues.apache.org/jira/browse/RANGER-2922 > > > Repository: ranger > > > Description > ------- > > Added code to audit events for document level authorization in solr. Also > updated UI code to read and show the solr query information from requestData > field of access audit event. > > > Diffs > ----- > > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 5b9241a0d > security-admin/src/main/webapp/scripts/utils/XAEnums.js fd711fa80 > security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 9c2af5fd5 > > > Diff: https://reviews.apache.org/r/72700/diff/1/ > > > Testing > ------- > > 1.Patched cluster and verified request by enabling Document level > authorization in solr. > 2.Verified all the unit tests are passign for any regression > > > Thanks, > > Sailaja Polavarapu > >
