----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72700/#review221396 -----------------------------------------------------------
plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Line 208 (original), 207 (patched) <https://reviews.apache.org/r/72700/#comment310342> As we discussed, initialization of solrPlugin object also can be included in the synchronized block, such that only one thread completes the creation and complete initialization of solrPlugin object. plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java Lines 442 (patched) <https://reviews.apache.org/r/72700/#comment310339> Consider moving this line to before line 452. - Abhay Kulkarni On July 21, 2020, 10:51 p.m., Sailaja Polavarapu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72700/ > ----------------------------------------------------------- > > (Updated July 21, 2020, 10:51 p.m.) > > > Review request for ranger, Abhay Kulkarni, Mehul Parikh, Ramesh Mani, and > Velmurugan Periasamy. > > > Bugs: RANGER-2922 > https://issues.apache.org/jira/browse/RANGER-2922 > > > Repository: ranger > > > Description > ------- > > Added code to audit events for document level authorization in solr. Also > updated UI code to read and show the solr query information from requestData > field of access audit event. > > > Diffs > ----- > > > plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java > 5b9241a0d > security-admin/src/main/webapp/scripts/utils/XAEnums.js fd711fa80 > security-admin/src/main/webapp/scripts/utils/XAViewUtils.js 9c2af5fd5 > > > Diff: https://reviews.apache.org/r/72700/diff/1/ > > > Testing > ------- > > 1.Patched cluster and verified request by enabling Document level > authorization in solr. > 2.Verified all the unit tests are passign for any regression > > > Thanks, > > Sailaja Polavarapu > >
