----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/72834/#review221813 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On Sept. 3, 2020, 12:28 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/72834/ > ----------------------------------------------------------- > > (Updated Sept. 3, 2020, 12:28 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Gautam Borad, > Jayendra Parab, Kishor Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, > Mahesh Bandal, Mehul Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-2946 > https://issues.apache.org/jira/browse/RANGER-2946 > > > Repository: ranger > > > Description > ------- > > Upgrade Bootstrap.js and related library. > > Also need to update x-editable, font-awesome, backbone form library. > > > Diffs > ----- > > security-admin/src/main/webapp/fonts/FontAwesome.otf PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome-webfont.eot PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome-webfont.svg PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome-webfont.ttf PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome-webfont.woff PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome-webfont.woff2 PRE-CREATION > security-admin/src/main/webapp/fonts/fontawesome/FontAwesome.otf > 70125459f7d593b79cabc75bd60b91943aa65e93 > security-admin/src/main/webapp/fonts/fontawesome/fontawesome-webfont.eot > 0662cb96bfb78cb2603df4bc9995314bd6806312 > security-admin/src/main/webapp/fonts/fontawesome/fontawesome-webfont.svg > 2edb4ec > security-admin/src/main/webapp/fonts/fontawesome/fontawesome-webfont.ttf > d3659246915cacb0c9204271f1f9fc5f77049eac > security-admin/src/main/webapp/fonts/fontawesome/fontawesome-webfont.woff > b9bd17e158d87fb1477f7ac3ddbb5a676f3c26d2 > security-admin/src/main/webapp/index.html 7efc9cb > security-admin/src/main/webapp/libs/bower/backbone-forms/css/old.css > PRE-CREATION > > security-admin/src/main/webapp/libs/bower/backbone-forms/js/backbone-forms.js > 13dfe62 > > security-admin/src/main/webapp/libs/bower/backbone-forms/js/backbone-forms.min.js > 36e34bf > security-admin/src/main/webapp/libs/bower/backbone-forms/js/bootstrap.js > b8e4384 > security-admin/src/main/webapp/libs/bower/backbone-forms/js/list.js 082e099 > security-admin/src/main/webapp/libs/bower/backbone-forms/js/list.min.js > ce7eb66 > security-admin/src/main/webapp/libs/bower/backbone-forms/js/old.js e3efe55 > > security-admin/src/main/webapp/libs/bower/backbone.bootstrap-modal/js/backbone.bootstrap-modal.js > 7c5efc2 > security-admin/src/main/webapp/libs/bower/bootbox/js/bootbox.js f6c6661 > > security-admin/src/main/webapp/libs/bower/bootstrap-notify/js/bootstrap-notify.js > ba309e2 > security-admin/src/main/webapp/libs/bower/bootstrap/js/bootstrap.js 5f7b318 > security-admin/src/main/webapp/libs/bower/bootstrap/js/bootstrap.min.js > 01ae673 > > security-admin/src/main/webapp/libs/bower/moment/js/moment-with-locales.min.js > ef637c0 > security-admin/src/main/webapp/libs/bower/select2/select2-bootstrap4.css > PRE-CREATION > > security-admin/src/main/webapp/libs/bower/x-editable/css/bootstrap-editable.css > b58adb9 > security-admin/src/main/webapp/libs/bower/x-editable/img/loading.gif > PRE-CREATION > > security-admin/src/main/webapp/libs/bower/x-editable/js/bootstrap-editable.js > 86d34da > > security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/css/bootstrap-datetimepicker.min.css > 78485fe > > security-admin/src/main/webapp/libs/other/bootstrap-datetimepicker/js/bootstrap-datetimepicker.min.js > eba15ce > > security-admin/src/main/webapp/libs/other/daterangepicker/css/daterangepicker.css > PRE-CREATION > > security-admin/src/main/webapp/libs/other/daterangepicker/js/daterangepicker.js > PRE-CREATION > security-admin/src/main/webapp/login.jsp a725247 > security-admin/src/main/webapp/scripts/Init.js a176e53 > security-admin/src/main/webapp/scripts/Main.js 5064faa > security-admin/src/main/webapp/scripts/controllers/NController.js 8dc78c6 > security-admin/src/main/webapp/scripts/models/BackboneFormDataType.js > 73b807b > security-admin/src/main/webapp/scripts/models/RangerPolicy.js 9f7b86f > security-admin/src/main/webapp/scripts/models/RangerServiceDef.js aeb581e > security-admin/src/main/webapp/scripts/modules/XAOverrides.js d6b8281 > security-admin/src/main/webapp/scripts/prelogin/XAPrelogin.js 0ca24fc > security-admin/src/main/webapp/scripts/routers/Router.js 7c893e5 > security-admin/src/main/webapp/scripts/utils/XAUtils.js 58b305b > security-admin/src/main/webapp/scripts/utils/XAViewUtils.js d8251a4 > security-admin/src/main/webapp/scripts/views/DownloadServicePolicy.js > f701e3f > security-admin/src/main/webapp/scripts/views/UploadServicePolicy.js 060d2e2 > security-admin/src/main/webapp/scripts/views/common/AddGroup.js 8f9fe03 > security-admin/src/main/webapp/scripts/views/common/CustomSubgrid.js > ad89a13 > security-admin/src/main/webapp/scripts/views/common/Spinner.js 12bad9a > security-admin/src/main/webapp/scripts/views/common/UserPermissionList.js > 58da18c > security-admin/src/main/webapp/scripts/views/kms/KMSTableLayout.js 5f8d068 > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermissionForm.js > 8c3ec3d > > security-admin/src/main/webapp/scripts/views/permissions/ModulePermsTableLayout.js > aefcf45 > > security-admin/src/main/webapp/scripts/views/policies/NRangerPolicyTableLayout.js > a4e8c86 > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > 9f6af3e > security-admin/src/main/webapp/scripts/views/policies/PolicyTimeList.js > 919959c > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyCreate.js > bb2752d > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyForm.js > 0b64e6a > > security-admin/src/main/webapp/scripts/views/policies/RangerPolicyTableLayout.js > fa94d6c > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayout.js > 2787019 > > security-admin/src/main/webapp/scripts/views/policymanager/ServiceLayoutSidebar.js > 452858d > security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js bdabe6f > security-admin/src/main/webapp/scripts/views/reports/UserAccessLayout.js > 166eca0 > security-admin/src/main/webapp/scripts/views/security_zone/SecurityZone.js > dfdc0e1 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneAdministration.js > f25ff8c > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneCreateForm.js > 9e7e430 > > security-admin/src/main/webapp/scripts/views/security_zone/ZoneResourceForm.js > a23c744 > security-admin/src/main/webapp/scripts/views/service/ServiceCreate.js > 7cc1654 > security-admin/src/main/webapp/scripts/views/users/RoleCreate.js e40eb87 > security-admin/src/main/webapp/scripts/views/users/UserForm.js d556013 > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > cc3bf80 > security-admin/src/main/webapp/styles/bootstrap.css 3c48696 > security-admin/src/main/webapp/styles/bootstrap.min.css 3c48696 > security-admin/src/main/webapp/styles/font-awesome.min.css PRE-CREATION > security-admin/src/main/webapp/styles/xa.css a070f8c > security-admin/src/main/webapp/templates/common/AddGroup_tmpl.html 3a5d531 > security-admin/src/main/webapp/templates/common/ErrorView_tmpl.html 3a744c3 > security-admin/src/main/webapp/templates/common/ProfileBar_tmpl.html > 28039ef > > security-admin/src/main/webapp/templates/common/ServiceManagerLayout_tmpl.html > 32f0fc3 > > security-admin/src/main/webapp/templates/common/ServiceManagerSidebarLayout_tmpl.html > 6fec086 > security-admin/src/main/webapp/templates/common/ServiceMappingItem.html > c3391c4 > security-admin/src/main/webapp/templates/common/TopNav_tmpl.html 4bbf59d > security-admin/src/main/webapp/templates/common/UserPermissionItem.html > 28baacf > security-admin/src/main/webapp/templates/common/UserPermissionList.html > e7fee52 > > security-admin/src/main/webapp/templates/common/downloadservicepolicy_tmpl.html > 95ea335 > > security-admin/src/main/webapp/templates/common/uploadservicepolicy_tmpl.html > bf89303 > security-admin/src/main/webapp/templates/helpers/XAHelpers.js ac06ef4 > security-admin/src/main/webapp/templates/kms/KmsKeyCreate_tmpl.html 1dd8ae8 > security-admin/src/main/webapp/templates/kms/KmsTableLayout_tmpl.html > f4d681b > > security-admin/src/main/webapp/templates/permissions/ModulePermissionCreate_tmpl.html > 2c9f4d9 > > security-admin/src/main/webapp/templates/permissions/ModulePermissionForm_tmpl.html > 909d2fc > > security-admin/src/main/webapp/templates/permissions/ModulePermsTableLayout_tmpl.html > 8fe1b58 > security-admin/src/main/webapp/templates/policies/PermissionItem.html > 3e60e6e > security-admin/src/main/webapp/templates/policies/PermissionList.html > 96dcb95 > security-admin/src/main/webapp/templates/policies/PolicyTimeItem_tmpl.html > 488babb > security-admin/src/main/webapp/templates/policies/PolicyTimeList_tmpl.html > 0eea670 > > security-admin/src/main/webapp/templates/policies/RangerPolicyCreate_tmpl.html > 0151e7c > > security-admin/src/main/webapp/templates/policies/RangerPolicyForm_tmpl.html > ffea44d > security-admin/src/main/webapp/templates/policies/RangerPolicyRO_tmpl.html > a03e2dd > > security-admin/src/main/webapp/templates/policies/RangerPolicyTableLayout_tmpl.html > 496561f > > security-admin/src/main/webapp/templates/reports/AssetOperationDiff_tmpl.html > e6bd359 > > security-admin/src/main/webapp/templates/reports/AssetUpdateOperationDiff_tmpl.html > 7874341 > > security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html > ec6795f > security-admin/src/main/webapp/templates/reports/AuditLayout_tmpl.html > fa03fc2 > > security-admin/src/main/webapp/templates/reports/GroupOperationDiff_tmpl.html > 1677be2 > > security-admin/src/main/webapp/templates/reports/GroupUpdateOperationDiff_tmpl.html > 04ba402 > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDeleteDiff_tmpl.html > f37c158 > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyDiff_tmpl.html > 59fa1f3 > > security-admin/src/main/webapp/templates/reports/PlugableServicePolicyUpdateDiff_tmpl.html > 4c00a8a > > security-admin/src/main/webapp/templates/reports/RoleOperationDiff_tmpl.html > 6d04887 > > security-admin/src/main/webapp/templates/reports/RoleUpdateOperationDiff_tmpl.html > f0eb085 > security-admin/src/main/webapp/templates/reports/UserAccessLayout_tmpl.html > 956fb32 > > security-admin/src/main/webapp/templates/reports/UserOperationDiff_tmpl.html > 669869d > > security-admin/src/main/webapp/templates/reports/UserUpdateOperationDiff_tmpl.html > 0123f0c > > security-admin/src/main/webapp/templates/reports/ZoneOperationDiff_tmpl.html > e0d5eac > > security-admin/src/main/webapp/templates/reports/ZoneUpdateOperationDiff_tmpl.html > 8563ab2 > > security-admin/src/main/webapp/templates/security_zone/SecurityZone_tmpl.html > 0a9fbb5 > > security-admin/src/main/webapp/templates/security_zone/ZoneAdministration_tmpl.html > d883d5f > > security-admin/src/main/webapp/templates/security_zone/ZoneCreateForm_tmpl.html > 779119a > security-admin/src/main/webapp/templates/security_zone/ZoneCreate_tmpl.html > a60eced > > security-admin/src/main/webapp/templates/security_zone/ZoneResourceForm_tmpl.html > cdd9d5e > > security-admin/src/main/webapp/templates/security_zone/ZoneResourceItem_tmpl.html > 72033ce > > security-admin/src/main/webapp/templates/security_zone/ZoneResourceList_tmpl.html > 9a532b3 > > security-admin/src/main/webapp/templates/security_zone/ZoneResourcesForm_tmpl.html > 4b7d6eb > > security-admin/src/main/webapp/templates/security_zone/ZoneResources_tmpl.html > dc48e7a > > security-admin/src/main/webapp/templates/service/ConfigurationItem_tmpl.html > 6d330c4 > > security-admin/src/main/webapp/templates/service/ConfigurationList_tmpl.html > 3e59836 > > security-admin/src/main/webapp/templates/service/RangerServiceViewDetail_tmpl.html > 978d785 > security-admin/src/main/webapp/templates/service/ServiceCreate_tmpl.html > dff0b66 > security-admin/src/main/webapp/templates/service/ServiceForm_tmpl.html > 391b68a > > security-admin/src/main/webapp/templates/service/ServiceTableLayout_tmpl.html > 970bd06 > security-admin/src/main/webapp/templates/user/UserProfileForm_tmpl.html > 6dfa39b > security-admin/src/main/webapp/templates/user/UserProfile_tmpl.html da5ef58 > > security-admin/src/main/webapp/templates/users/AddUserOrGroupsItem_tmpl.html > 0f264fd > > security-admin/src/main/webapp/templates/users/AddUserOrGroupsList_tmpl.html > 1371f47 > security-admin/src/main/webapp/templates/users/GroupCreate_tmpl.html > 26833b4 > security-admin/src/main/webapp/templates/users/GroupForm_tmpl.html c2c8b6a > security-admin/src/main/webapp/templates/users/RoleCreate_tmpl.html efcdb55 > security-admin/src/main/webapp/templates/users/RoleForm_tmpl.html 460a823 > security-admin/src/main/webapp/templates/users/UserCreate_tmpl.html b11cc36 > security-admin/src/main/webapp/templates/users/UserForm_tmpl.html 209b261 > security-admin/src/main/webapp/templates/users/UserInfo_tmpl.html 350e2b2 > security-admin/src/main/webapp/templates/users/UserTableLayout_tmpl.html > 4a9745c > > > Diff: https://reviews.apache.org/r/72834/diff/1/ > > > Testing > ------- > > Tested Service CRUD. > Tested Policy CRUD. > Tested User/group/role CRUD. > Tested Import/export. > > > Thanks, > > Nitin Galave > >
