-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73032/
-----------------------------------------------------------

(Updated Nov. 25, 2020, 7:49 p.m.)


Review request for ranger and Madhan Neethiraj.


Changes
-------

Addressed review comments


Bugs: RANGER-3082
    https://issues.apache.org/jira/browse/RANGER-3082


Repository: ranger


Description
-------

When macros like {USER} are used in resource names, users with delegated-admin 
are unable to set up policies.


Diffs (updated)
-----

  
agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java
 3250719de 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java
 f3e0dab2f 
  
agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java
 14b626df6 
  
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerAccessRequestUtil.java
 a22027a46 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdmin.java 
e011c0bf5 
  security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java 
6fc0abf4b 
  security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java 
39869d385 


Diff: https://reviews.apache.org/r/73032/diff/2/

Changes: https://reviews.apache.org/r/73032/diff/1-2/


Testing
-------

Passed all unit tests. Tested by creating delegated-admin policies with {USER} 
embedded in resource name and ensured the designated user can set up policy 
with macro in the resource name expanded with designated user's name.


Thanks,

Abhay Kulkarni

Reply via email to