----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73032/#review222241 -----------------------------------------------------------
Ship it! Ship It! - Madhan Neethiraj On Nov. 26, 2020, 12:44 a.m., Abhay Kulkarni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73032/ > ----------------------------------------------------------- > > (Updated Nov. 26, 2020, 12:44 a.m.) > > > Review request for ranger and Madhan Neethiraj. > > > Bugs: RANGER-3082 > https://issues.apache.org/jira/browse/RANGER-3082 > > > Repository: ranger > > > Description > ------- > > When macros like {USER} are used in resource names, users with > delegated-admin are unable to set up policies. > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/plugin/policyengine/PolicyEngine.java > 3250719de > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerDefaultPolicyEvaluator.java > f3e0dab2f > > agents-common/src/main/java/org/apache/ranger/plugin/policyevaluator/RangerPolicyEvaluator.java > 14b626df6 > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdmin.java > e011c0bf5 > > security-admin/src/main/java/org/apache/ranger/biz/RangerPolicyAdminImpl.java > 6fc0abf4b > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > 39869d385 > > > Diff: https://reviews.apache.org/r/73032/diff/4/ > > > Testing > ------- > > Passed all unit tests. Tested by creating delegated-admin policies with > {USER} embedded in resource name and ensured the designated user can set up > policy with macro in the resource name expanded with designated user's name. > > > Thanks, > > Abhay Kulkarni > >
