----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73129/#review222432 -----------------------------------------------------------
hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java Line 348 (original), 348 (patched) <https://reviews.apache.org/r/73129/#comment311490> Consider following renaming: boolean auditOnlyIfDenied = context.isTraverseOnlyCheck && !checkIfSetOperation(context.operationName); hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java Lines 1111 (patched) <https://reviews.apache.org/r/73129/#comment311489> Does '2' mean NOT_DETERMINED? Shouldn't the result be know at this point - even if its using HDFS ACLs (fallback)? - Madhan Neethiraj On Jan. 11, 2021, 6:25 p.m., Ramesh Mani wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73129/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2021, 6:25 p.m.) > > > Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, > Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3148 > https://issues.apache.org/jira/browse/RANGER-3148 > > > Repository: ranger > > > Description > ------- > > RANGER-3148:Ranger auditing not happening for hdfs chown and chmod operations > > > Diffs > ----- > > > agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java > 31e4c0f4e > > hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java > 63e84728d > > > Diff: https://reviews.apache.org/r/73129/diff/1/ > > > Testing > ------- > > - Verified in local vm for auditing. > > > Thanks, > > Ramesh Mani > >
