-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73129/#review222493
-----------------------------------------------------------




hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
Lines 474 (patched)
<https://reviews.apache.org/r/73129/#comment311585>

    This doesn't look right. Can you please add a comment on why this is needed?


- Madhan Neethiraj


On Jan. 19, 2021, 6:01 a.m., Ramesh Mani wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73129/
> -----------------------------------------------------------
> 
> (Updated Jan. 19, 2021, 6:01 a.m.)
> 
> 
> Review request for ranger, Don Bosco Durai, Abhay Kulkarni, Madhan Neethiraj, 
> Mehul Parikh, Selvamohan Neethiraj, Sailaja Polavarapu, and Velmurugan 
> Periasamy.
> 
> 
> Bugs: RANGER-3148
>     https://issues.apache.org/jira/browse/RANGER-3148
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> RANGER-3148:Ranger auditing not happening for hdfs chown and chmod operations
> 
> 
> Diffs
> -----
> 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/constants/RangerHadoopConstants.java
>  31e4c0f4e 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  63e84728d 
> 
> 
> Diff: https://reviews.apache.org/r/73129/diff/4/
> 
> 
> Testing
> -------
> 
> - Verified in local vm for auditing.
> - Following operations and its auditing are covered.
> 
> 1) chmod ->  Allow and deny gets audited fine for all the calls.
> 2) chown  -> Deny gets audited for the file not owned by the same user who 
> runs the command.
> 
> 
> Thanks,
> 
> Ramesh Mani
> 
>

Reply via email to