-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73187/#review222620
-----------------------------------------------------------




agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
Lines 218 (patched)
<https://reviews.apache.org/r/73187/#comment311746>

    check the indentation



agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
Lines 687 (patched)
<https://reviews.apache.org/r/73187/#comment311747>

    remove this commented out code



knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
Lines 123 (patched)
<https://reviews.apache.org/r/73187/#comment311748>

    check the indentation.
    
    Do we really need this "ambari.policy.name"? please check once.



security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java
Lines 163 (patched)
<https://reviews.apache.org/r/73187/#comment311749>

    remove this info logger as we are already capturing in debug log. 
    Please check line no-161


- bhavik patel


On Feb. 19, 2021, 6:21 a.m., Bhagyashri Kokate wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73187/
> -----------------------------------------------------------
> 
> (Updated Feb. 19, 2021, 6:21 a.m.)
> 
> 
> Review request for ranger, Dhaval Rajpara, Dineshkumar Yadav, Jayendra Parab, 
> Kishor Gollapalliwar, Mehul Parikh, and Pradeep Agrawal.
> 
> 
> Bugs: RANGER-3158
>     https://issues.apache.org/jira/browse/RANGER-3158
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> Feature within Ranger to filter/search by a policy by name.
> 
> This is found within the Audit -> Access -> Search box. Currently one can 
> only search by policy id. (and not policy name)
> 
> 
> Diffs
> -----
> 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/destination/SolrAuditDestination.java
>  5a7a7f43b 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/model/AuthzAuditEvent.java 
> 28db58cd9 
>   
> agents-audit/src/main/java/org/apache/ranger/audit/provider/solr/SolrAuditProvider.java
>  1ef115a87 
>   
> agents-common/src/main/java/org/apache/ranger/admin/client/RangerAdminRESTClient.java
>  9d527bf0a 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerChainedPluginConfig.java
>  de2aff1a3 
>   
> agents-common/src/main/java/org/apache/ranger/authorization/hadoop/config/RangerPluginConfig.java
>  7b34f77da 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/audit/RangerDefaultAuditHandler.java
>  427372643 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequest.java
>  6a38747f4 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestImpl.java
>  74a7a2615 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessRequestReadOnly.java
>  4887c0112 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerAccessResult.java
>  407e3e747 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/policyengine/RangerPolicyEngineImpl.java
>  4e0c98e9e 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/service/RangerBasePlugin.java
>  fda57f947 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/GrantRevokeRequest.java
>  63f0f2598 
>   
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerRESTUtils.java
>  adf0c0a67 
>   
> hdfs-agent/src/main/java/org/apache/ranger/authorization/hadoop/RangerHdfsAuthorizer.java
>  63e84728d 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAccessRequest.java
>  deb467f7f 
>   
> hive-agent/src/main/java/org/apache/ranger/authorization/hive/authorizer/RangerHiveAuthorizer.java
>  5bd5c2da4 
>   
> knox-agent/src/main/java/org/apache/ranger/admin/client/RangerAdminJersey2RESTClient.java
>  1beef8607 
>   
> plugin-solr/src/main/java/org/apache/ranger/authorization/solr/authorizer/RangerSolrAuthorizer.java
>  1ebd0bf6e 
>   security-admin/contrib/solr_for_audit_setup/conf/managed-schema c33f6de06 
>   security-admin/src/main/java/org/apache/ranger/AccessAuditsService.java 
> e902e65d0 
>   security-admin/src/main/java/org/apache/ranger/rest/AssetREST.java 
> 51d000e04 
>   
> security-admin/src/main/java/org/apache/ranger/service/XAccessAuditService.java
>  cc23d39fb 
>   
> security-admin/src/main/java/org/apache/ranger/service/XPolicyExportAuditService.java
>  01c56e9e1 
>   
> security-admin/src/main/java/org/apache/ranger/solr/SolrAccessAuditsService.java
>  0aea46d1b 
>   security-admin/src/main/java/org/apache/ranger/solr/SolrUtil.java 3ba8a3e20 
>   security-admin/src/main/java/org/apache/ranger/view/VXAccessAudit.java 
> 4dfd20754 
>   security-admin/src/main/webapp/scripts/views/reports/AuditLayout.js 
> 0b24c10eb 
>   
> security-admin/src/main/webapp/templates/reports/AuditAccessLogDetail_tmpl.html
>  b3e2c6606 
>   security-admin/src/test/java/org/apache/ranger/rest/TestServiceREST.java 
> 09d3beac2 
> 
> 
> Diff: https://reviews.apache.org/r/73187/diff/2/
> 
> 
> Testing
> -------
> 
> Testing
> 
> 
> Thanks,
> 
> Bhagyashri Kokate
> 
>

Reply via email to