----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73264/#review222782 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On April 5, 2021, 11:41 a.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73264/ > ----------------------------------------------------------- > > (Updated April 5, 2021, 11:41 a.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul > Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-3228 > https://issues.apache.org/jira/browse/RANGER-3228 > > > Repository: ranger > > > Description > ------- > > 1)In tag service permission for audit filter not populate properly. > 2) Show audit filter data in readable format instead of just json value in > service detail view popup. > 3)When Save the Resources and then click on Cancel icon then there should be > Add icon besides it instead of Edit iocn. > 4)When I do delete audit filter then there should be message under audit > filter required saying:No Audit filter Data Found.!! > 5)Observed that there is no select dropdown for the operations column while > configuring audit filters. While the placeholder hint is displayed as Select > Action. we should add an apt placeholder/tooltip with a message like, "Type > Action Name". > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/modules/globalize/message/en.js > 3bc933f > security-admin/src/main/webapp/scripts/views/service/AuditFilterConfig.js > f5e01f2 > > security-admin/src/main/webapp/scripts/views/service/RangerServiceViewDetail.js > 0c637ab > security-admin/src/main/webapp/scripts/views/service/ServiceForm.js 668fa79 > security-admin/src/main/webapp/templates/service/AuditFilterList_tmpl.html > 268917a > > security-admin/src/main/webapp/templates/service/RangerServiceViewDetail_tmpl.html > af86930 > > > Diff: https://reviews.apache.org/r/73264/diff/2/ > > > Testing > ------- > > Verified the following areas in tag based audit filters: > > 1. Whether tags created in Atlas appear properly in the Resources lookup > 2. Checked whether Permissions change in the modal dialog box based on the > component selected in UI. > 3. Users, Groups, and Roles lookup works properly for new users, groups and > roles. > 4. Audit filter rows are getting saved and deleted, and whether drag and drop > facility works in Audit filters. > 5. When Save the Resources and then click on Cancel icon then there should be > Add icon besides it instead of Edit iocn. > 6. When audit filter section is empty then there should be message under > audit filter required saying:No Audit filter Data Found.!!. > 7. Added correct massage to Operations dropdow "Type Action Name". > > > Thanks, > > Nitin Galave > >
