----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73501/#review223337 -----------------------------------------------------------
Ship it! Ship It! - Mehul Parikh On Aug. 4, 2021, 12:23 p.m., Nitin Galave wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73501/ > ----------------------------------------------------------- > > (Updated Aug. 4, 2021, 12:23 p.m.) > > > Review request for ranger, Dhaval Shah, Dineshkumar Yadav, Harshal Chavan, > Jayendra Parab, Kishor Gollapalliwar, Madhan Neethiraj, Mahesh Bandal, Mehul > Parikh, Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-3362 > https://issues.apache.org/jira/browse/RANGER-3362 > > > Repository: ranger > > > Description > ------- > > Issue 1: Even the checkbox is selected still during deletion of role > prompting pop up saying " Select the role first". > > > Steps: > 1.Create policy and associate any role to it. > 2.Try to delete that role - select the role and click on delete icon- > 3.Again try to delete the same role and observe- It will ask to select a role > again but role is already selected > > Actual Result: > > > > Issue 2: Not able to save the policy when I removed the role / group and > permissions during updating. > > Steps: > > 1.Create a policy and associate the role/group to it and save the policy. > > 2.Remove the role/group + permissions from the same policy ,click on save > and observe. > > Actual Result: Getting error message saying "error code[3020], reason[All of > users, user-groups and roles collections on the policy item were null/empty]". > > Expected Result: User should able to update the policy successfully. > > > Diffs > ----- > > security-admin/src/main/webapp/scripts/views/policies/PermissionList.js > e4ea25f7e > security-admin/src/main/webapp/scripts/views/users/UserTableLayout.js > b8270d962 > > > Diff: https://reviews.apache.org/r/73501/diff/1/ > > > Testing > ------- > > 1. To Verify Proper error message is shown while deleting the user and group > which are associated with the role. > 2.To verify proper error message is shown while deleting the user and group > which are associated with the zone. > 3.To verify user is able to create,update and delete the policy and associate > any user,role and group for the same. > 4.To verify user is able to create a service properly and associate user,role > and group for the same. > 5.To Verify when any role,user and group is associated with the service in > the audit filter then after deleting that particular role,group and user the > same has been removed from the audit filter. > 6.To verify if any role is associated with the policy then that role should > not be deleted. > 7.To verify user user is able to create,update and delete the role > successfully. > > > Thanks, > > Nitin Galave > >
