----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73568/#review223450 -----------------------------------------------------------
Ship it! Ship It! - Vishal Suvagia On Sept. 6, 2021, 7:44 a.m., Kishor Gollapalliwar wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73568/ > ----------------------------------------------------------- > > (Updated Sept. 6, 2021, 7:44 a.m.) > > > Review request for ranger, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, > Pradeep Agrawal, and Velmurugan Periasamy. > > > Bugs: RANGER-3398 > https://issues.apache.org/jira/browse/RANGER-3398 > > > Repository: ranger > > > Description > ------- > > Duplicate JAVA suffix is allowed. Currently we need a manual human > intervention to find and correct. Use case in details as follows. > > ## Use-Case: > > 1. Say user1 & user2 working on a fix in Ranger and they both need JAVA patch > changes. > 2. Assume user1 needs to update table1 and user2 needs to update table2 using > java. > 3. Both Checked latest JAVA patch suffix (say it is _J10050). And used suffix > _J10051 for their JAVA files > 4. If both commits ends up merging. The setup script will apply ONLY one of > the both JAVA files (suffixed _J10051) randomly. > > ## Reproduce Steps: > > 1. cd <ranger-repo>/security-admin/src/main/java/org/apache/ranger/patch/ > 2. Update suffix of last 2 patches such that both contains same suffix > 3. mvn clean compile package install -U #build ranger > 4. setup ranger > > To avoid this, we need to fail maven build itself if there are duplicate > suffix. > > > Diffs > ----- > > security-admin/pom.xml 7ee2b22b2 > > > Diff: https://reviews.apache.org/r/73568/diff/1/ > > > Testing > ------- > > ## In-Valid cases > > 1. Same prefixed files inside patches directory > 2. Same prefixed files inside audit directory > 3. Same prefixed files first inside patches second inside audit directory > > ## Valid cases > > 1. NO duplicate prefix > > ## Build > > mvn clean compile package install -U > > > Thanks, > > Kishor Gollapalliwar > >
