-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73564/#review223457
-----------------------------------------------------------



I think this is not a proper solution as TEXT data type use more memory for 
sorting as require the use of a disk-based temporary table and this might also 
impact performance.

Try to udpate the varchar size to 256-512 and you need to create sql patch for 
the same.

Also, try to provide patch for all the DB flavor.


security-admin/src/main/resources/log4jdbc.properties
Line 16 (original), 16 (patched)
<https://reviews.apache.org/r/73564/#comment312539>

    this change belongs to RANGER-3393


- bhavik patel


On Sept. 1, 2021, 11:48 p.m., Tsung-Ju Lii wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73564/
> -----------------------------------------------------------
> 
> (Updated Sept. 1, 2021, 11:48 p.m.)
> 
> 
> Review request for ranger.
> 
> 
> Repository: ranger
> 
> 
> Description
> -------
> 
> The patch is just substituting all occurrences of `varchar(4000)` with 
> `TEXT`. Probably not the best way to do this but it works for me.
> 
> 
> Diffs
> -----
> 
>   security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql 
> 8e925e5d7 
>   security-admin/src/main/resources/log4jdbc.properties 30cda789f 
> 
> 
> Diff: https://reviews.apache.org/r/73564/diff/1/
> 
> 
> Testing
> -------
> 
> After I applied this patch I was able to deploy using MySQL. Without it the 
> deploy would fail.
> 
> 
> Thanks,
> 
> Tsung-Ju Lii
> 
>

Reply via email to