> On Sept. 9, 2021, 1:18 p.m., Pradeep Agrawal wrote: > > Please propose changes only for the column you are facing the issue. > > Tsung-Ju Lii wrote: > My issue was that the `varchar(4000)`s in the code made deployment > impossible due to MySQL complaining about row size exceeding max table size. > > If there are actually columns that are supposed to have 4000 characters > then I'll change them back, but for now I don't really see why you'd need > 4000 characters for any of the columns.
Tsung-Ju Lii - which table(s) did MySQL compained about row size? Reducing the size can break existing deployments having data longer than 256 characters in modified columns. As Pradeep suggested, please minimize the scope of this change to a small set of columns. Also, it is important to verify that there is no data loss due to this patch, perhaps by using a Java patch that scans the modified columns for data longer than the new limit. - Madhan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73564/#review223465 ----------------------------------------------------------- On Sept. 8, 2021, 6:57 p.m., Tsung-Ju Lii wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73564/ > ----------------------------------------------------------- > > (Updated Sept. 8, 2021, 6:57 p.m.) > > > Review request for ranger. > > > Repository: ranger > > > Description > ------- > > The patch is just substituting all occurrences of `varchar(4000)` with > `varchar(256)` in `core_db.sql` files. > > > Diffs > ----- > > security-admin/db/mysql/optimized/current/ranger_core_db_mysql.sql > 8e925e5d7 > security-admin/db/oracle/optimized/current/ranger_core_db_oracle.sql > 638d9fbf2 > security-admin/db/postgres/optimized/current/ranger_core_db_postgres.sql > 500e83f01 > > security-admin/db/sqlanywhere/optimized/current/ranger_core_db_sqlanywhere.sql > 0048e504c > > > Diff: https://reviews.apache.org/r/73564/diff/2/ > > > Testing > ------- > > After I applied this patch I was able to deploy using MySQL. Without it the > deploy would fail. > > > Thanks, > > Tsung-Ju Lii > >
