----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73601/#review223605 -----------------------------------------------------------
security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java Lines 3762 (patched) <https://reviews.apache.org/r/73601/#comment312711> Please consider exposing these APIs through PublicAPIsv2 REST interface, and update the public REST documentation accordingly. - Abhay Kulkarni On Sept. 22, 2021, 11:03 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73601/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2021, 11:03 a.m.) > > > Review request for ranger, Dineshkumar Yadav, Abhay Kulkarni, Madhan > Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan > Periasamy. > > > Bugs: RANGER-3439 > https://issues.apache.org/jira/browse/RANGER-3439 > > > Repository: ranger > > > Description > ------- > > **Problem Statmeent: ** This is required after the analysys of RANGER-3401, > as there could be request on x_policy table to find a policy by guid and > service id. There is no workaround to this problem however its recommended > that similar option should be provided through a REST url. > > > **Proposed solution:** A New API can be introduced which shall accept the > guid and service name as request parameter input and either provide the > respective policy or delete the same. > API: > a) getPolicyByGUIDAndServiceName(guid, service): reads the input values and > returns the policy object. > b) deletePolicyByGUIDAndServiceName(guid, service) : reads the input values > and deletes the respective policy object. > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java > 3cd289cc2 > security-admin/src/main/java/org/apache/ranger/db/XXPolicyDao.java > 865926706 > security-admin/src/main/java/org/apache/ranger/rest/ServiceREST.java > f1123d19c > security-admin/src/main/resources/META-INF/jpa_named_queries.xml 8eff33643 > > > Diff: https://reviews.apache.org/r/73601/diff/1/ > > > Testing > ------- > > Tested getPolicyByGUIDAndServiceName() API and was able to recieve the > matching policy object. > Tested deletePolicyByGUIDAndServiceName() API and was able to delete the > respective policy object. > > > Thanks, > > Pradeep Agrawal > >
