----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/73767/#review223875 -----------------------------------------------------------
Ship it! Ship It! - bhavik patel On Dec. 17, 2021, 9:33 a.m., Pradeep Agrawal wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/73767/ > ----------------------------------------------------------- > > (Updated Dec. 17, 2021, 9:33 a.m.) > > > Review request for ranger, bhavik patel, Dineshkumar Yadav, Kishor > Gollapalliwar, Abhay Kulkarni, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, > Sailaja Polavarapu, and Velmurugan Periasamy. > > > Bugs: RANGER-3553 > https://issues.apache.org/jira/browse/RANGER-3553 > > > Repository: ranger > > > Description > ------- > > **Problem Statement:** Unit test coverage for UserMgr class need to be > increased. > > > Currently Unit Test coverage of UserMgr is 79% > Total No. of test cases in TestUserMgr class are: 41 > > > **Proposed Improvement:** > Proposed patch contains 10 additional unit test cases and modification in > several existing unit test cases. > > > **Statistics after the patch are:** > Test coverage of UserMgr after this patch will be 91% > Total No. of test cases in TestUserMgr class will be: 51 > > > Diffs > ----- > > security-admin/src/main/java/org/apache/ranger/biz/UserMgr.java 91144fb4a > security-admin/src/test/java/org/apache/ranger/biz/TestUserMgr.java > 931a9ad79 > > > Diff: https://reviews.apache.org/r/73767/diff/1/ > > > Testing > ------- > > All testcases are running fine and build was successful. > > > Thanks, > > Pradeep Agrawal > >
